lkml.org 
[lkml]   [2007]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] sysctl: Don't compile sysctl_check when !CONFIG_SYSCTL
Date
Randy Dunlap <randy.dunlap@oracle.com> writes:

> On Thu, 18 Oct 2007 21:27:16 -0700 Avuton Olrich wrote:
>
>> Good Day,
>>
>> My randconfig just caught an error on:
>> kernel/built-in.o: In function `sysctl_check_lookup':
>> sysctl_check.c:(.text+0x17db1): undefined reference to `sysctl_head_next'
>> sysctl_check.c:(.text+0x17dc7): undefined reference to `sysctl_head_finish'
>>
>> Git bisect was unsuccessful due to too many unrelated errors trying to
>> track down the issue. I also couldn't track down the offending
>> function. Any idea of the issue?
>>
>> Against this config: http://avuton.googlepages.com/sysctl-head-next.config
>>
>> git master: 4fa4d23fa20de67df919030c1216295664866ad7
>
> Eric,
>
> Please have a look at this one.
>
> .config file link is above.
>
> # CONFIG_SYSCTL_SYSCALL is not set
> # CONFIG_PROC_SYSCTL is not set
>

Weird I thought I had written the makefile so this would be handled.
Oh well this should fix it.

Sorry about that.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
kernel/Makefile | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/Makefile b/kernel/Makefile
index 05c3e6d..79f017e 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -9,8 +9,9 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o profile.o \
rcupdate.o extable.o params.o posix-timers.o \
kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o \
hrtimer.o rwsem.o latency.o nsproxy.o srcu.o \
- utsname.o sysctl_check.o notifier.o
+ utsname.o notifier.o

+obj-$(CONFIG_SYSCTL) += sysctl_check.o
obj-$(CONFIG_STACKTRACE) += stacktrace.o
obj-y += time/
obj-$(CONFIG_DEBUG_MUTEXES) += mutex-debug.o
--
1.5.3.rc6.17.g1911
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-20 02:27    [W:0.037 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site