lkml.org 
[lkml]   [2007]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/9] irq-remove: arch non-trivial
    Date
    Jeff Garzik <jeff@garzik.org> writes:

    > Eric W. Biederman wrote:
    >> In this case we can easily pass the irqno into request_irq, allowing
    >> us to do "unsigned int intno = (unsigned int)dev_id;".
    >>
    >> I suspect this is the case for the majority of the non-trivial users
    >> as well.
    >
    >
    > Not that easy, alas :) Save for weirdos like the mac drivers I highlighted, it
    > seems like most drivers in the non-trivial already pass a useful pointer to
    > request_irq().

    I was talking about vm86_32.c in particular. Where we allow user space
    through the vm86 interface to directly handle the isa irq.

    > But as I mentioned, most of the "non-trivial" uses are actually trivial -- just
    > not as simple as removing the 'int irq' argument. Most of the time the irq
    > number is used in non-critical ways like printk's. A few times its used to
    > index into a structure (something dev_id could replace).

    Yes.

    Eric
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-19 21:41    [W:0.021 / U:31.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site