Messages in this thread Patch in this message | | | Date | Fri, 19 Oct 2007 13:46:15 +1000 | From | Greg Ungerer <> | Subject | [M68KNOMMU]: improve mii_do_cmd code in FEC driver |
| |
From: Philippe De Muyter <phdm@macqel.be>
Improve the readability of mii_do_cmd().
Signed-off-by: Philippe De Muyter <phdm@macqel.be> Signed-off-by: Greg Ungerer <gerg@uclinux.org> ---
diff -Naurp linux-2.6.23/drivers/net/fec.c linux-2.6.23-uc0/drivers/net/fec.c --- linux-2.6.23/drivers/net/fec.c 2007-10-19 10:25:49.000000000 +1000 +++ linux-2.6.23-uc0/drivers/net/fec.c 2007-10-19 10:34:22.000000000 +1000 @@ -770,14 +768,11 @@ mii_queue(struct net_device *dev, int re static void mii_do_cmd(struct net_device *dev, const phy_cmd_t *c) { - int k; - if(!c) return; - for(k = 0; (c+k)->mii_data != mk_mii_end; k++) { - mii_queue(dev, (c+k)->mii_data, (c+k)->funct); - } + for (; c->mii_data != mk_mii_end; c++) + mii_queue(dev, c->mii_data, c->funct); } static void mii_parse_sr(uint mii_reg, struct net_device *dev) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |