lkml.org 
[lkml]   [2007]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH/RFA] sch_generic: fix carrier-on bug?
From
From: Jeff Garzik <jeff@garzik.org>
Date: Tue, 16 Oct 2007 17:55:55 -0400

> While looking at a net driver with the following construct,
>
> if (!netif_carrier_ok(dev))
> netif_carrier_on(dev);
>
> it stuck me that the netif_carrier_ok() check was redundant, since
> netif_carrier_on() checks bit __LINK_STATE_NOCARRIER anyway. This is
> the same reason why netif_queue_stopped() need not be called prior to
> netif_wake_queue().
>
> This is true, but there is however an unwanted side effect from assuming
> that netif_carrier_on() can be called multiple times: it touches the
> watchdog, regardless of pre-existing carrier state.
>
> The fix: move watchdog-up inside the bit-cleared code path.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

I see no problems with this patch, I'll apply it, thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-18 08:29    [W:0.034 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site