Messages in this thread | | | Date | Thu, 18 Oct 2007 14:06:53 +0800 | From | "Bryan Wu" <> | Subject | Re: [PATCH 02/10] Blackfin SPI driver: use new GPIO API and add error handling |
| |
On 10/13/07, David Brownell <david-b@pacbell.net> wrote: > On Thursday 11 October 2007, Bryan Wu wrote: > > On Thu, 2007-10-11 at 23:26 -0700, David Brownell wrote: > > > On Thursday 11 October 2007, Bryan Wu wrote: > > > > @@ -1182,12 +1198,9 @@ static int __init bfin5xx_spi_probe(struct platform_device *pdev) > > > > return -ENOMEM; > > > > } > > > > > > > > - if (peripheral_request(P_SPI0_SCK, DRV_NAME) || > > > > - peripheral_request(P_SPI0_MISO, DRV_NAME) || > > > > - peripheral_request(P_SPI0_MOSI, DRV_NAME) ) { > > > > - > > > > + if (setup_pin_mux(1)) { > > > > dev_err(&pdev->dev, ": Requesting Peripherals failed\n"); > > > > - goto out_error_queue_alloc; > > > > + goto out_error; > > > > } > > > > > > > > drv_data = spi_master_get_devdata(master); > > > > > > > > > > Still doesn't apply ... what tree are you generating this series against?? > > > > I apply this patch on Linus git tree at 2.6.23 tag > > Then why don't my copies of that tree have the lines flagged > above with "-" ?? > > In fact, if I look at the kernel.org GIT tree, it doesn't have > them either. Your tree must have somehow gotten a bunch of > private changes. >
Did you apply these patches, or I need resent a new patchset against latest Linus GIT tree? I noticed in latest GIT tree the Blackfin SPI driver are modified.
Thanks -Bryan Wu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |