Messages in this thread | | | Date | Thu, 18 Oct 2007 16:05:50 +0200 | From | Jens Axboe <> | Subject | Re: [bug] ata subsystem related crash with latest -git |
| |
On Thu, Oct 18 2007, Jens Axboe wrote: > On Thu, Oct 18 2007, Benny Halevy wrote: > > > return sg; > > > } > > > @@ -83,6 +96,9 @@ static inline struct scatterlist *sg_last(struct scatterlist *sgl, > > > ret = sg; > > > > > > #endif > > > +#ifdef CONFIG_DEBUG_SG > > > + BUG_ON(sgl[0].sg_magic != SG_MAGIC); > > > > can it also do BUG_ON(!sg_is_last(sg))? > > That would make sense, definitely. I'll add that.
BUG_ON(!sg_is_last(ret));
it should be, not sg. That's what I merged.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |