lkml.org 
[lkml]   [2007]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] snd: fix build bug with CONFIG_SND_HDA_CODEC_SIGMATEL=y && !CONFIG_SND_HDA_GENERIC

    fix build bug introduced with the recent sound merge:

    -------------->
    Subject: snd: fix build bug with CONFIG_SND_HDA_CODEC_SIGMATEL=y && !CONFIG_SND_HDA_GENERIC
    From: Ingo Molnar <mingo@elte.hu>

    randconfig build testing found this build bug:

    sound/built-in.o: In function `patch_stac9872':
    patch_sigmatel.c:(.text+0x6d6e7): undefined reference to `snd_hda_parse_generic_codec'

    patch_sigmatel.c depends on SND_HDA_GENERIC, for snd_hda_parse_generic_codec().

    to make it selectable, reorder SND_HDA_CODEC_SIGMATEL to after
    SND_HDA_GENERIC.

    with this fixed, the kernel builds fine.

    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    sound/pci/Kconfig | 17 +++++++++--------
    1 file changed, 9 insertions(+), 8 deletions(-)

    Index: linux/sound/pci/Kconfig
    ===================================================================
    --- linux.orig/sound/pci/Kconfig
    +++ linux/sound/pci/Kconfig
    @@ -525,14 +525,6 @@ config SND_HDA_CODEC_ANALOG
    Say Y here to include Analog Device HD-audio codec support in
    snd-hda-intel driver, such as AD1986A.

    -config SND_HDA_CODEC_SIGMATEL
    - bool "Build IDT/Sigmatel HD-audio codec support"
    - depends on SND_HDA_INTEL
    - default y
    - help
    - Say Y here to include IDT (Sigmatel) HD-audio codec support in
    - snd-hda-intel driver, such as STAC9200.
    -
    config SND_HDA_CODEC_VIA
    bool "Build VIA HD-audio codec support"
    depends on SND_HDA_INTEL
    @@ -581,6 +573,15 @@ config SND_HDA_GENERIC
    Say Y here to enable the generic HD-audio codec parser
    in snd-hda-intel driver.

    +config SND_HDA_CODEC_SIGMATEL
    + bool "Build IDT/Sigmatel HD-audio codec support"
    + depends on SND_HDA_INTEL
    + select SND_HDA_GENERIC
    + default y
    + help
    + Say Y here to include IDT (Sigmatel) HD-audio codec support in
    + snd-hda-intel driver, such as STAC9200.
    +
    config SND_HDA_POWER_SAVE
    bool "Aggressive power-saving on HD-audio"
    depends on SND_HDA_INTEL && EXPERIMENTAL
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-10-18 11:53    [W:0.024 / U:1.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site