lkml.org 
[lkml]   [2007]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] PHYLIB: IRQ event workqueue handling fixes
    From
    Date

    > Btw., since, because of this patch, I've had a one more look at phy.c
    > and there are a few more doubts, so this time I'll try to bother you
    > for real:

    .../...

    While there... is somebody interested in making the whole PHY lib
    operate a task level and use mutexes instead of spinlock ? I need that
    for drivers like EMAC (who use their own PHY layer for now), and I might
    even give a go at adapting phylib myself, but I'd like to take the
    temperature about it first.

    Basically, there is nothing in phylib that is performance critical or
    such that requires it to run at irq time and/or use locks. On the other
    hand, it complicates things in various areas. The most obvious one being
    that it prevents the network driver mii access callbacks from sleeping
    which can be annoying as MDIO can be slow, and some drivers have fancy
    muxes in there that are better off mutexed than spinlocked.

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-17 11:11    [W:0.020 / U:2.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site