Messages in this thread Patch in this message | | | From | Benjamin Herrenschmidt <> | Date | Thu, 18 Oct 2007 10:56:20 +1000 | Subject | [PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary |
| |
The siimage use an incorrect construct to access the other drive of a pair, causing it to access beyond an array boundary on non-0 interfaces. This fixes it by using the new ide_get_paired_drive() hepler instead.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> ---
drivers/ide/pci/siimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-work/drivers/ide/pci/siimage.c =================================================================== --- linux-work.orig/drivers/ide/pci/siimage.c 2007-10-18 10:42:56.000000000 +1000 +++ linux-work/drivers/ide/pci/siimage.c 2007-10-18 10:43:09.000000000 +1000 @@ -180,7 +180,7 @@ static void sil_set_pio_mode(ide_drive_t const u16 data_speed[] = { 0x328a, 0x2283, 0x1104, 0x10c3, 0x10c1 }; ide_hwif_t *hwif = HWIF(drive); - ide_drive_t *pair = &hwif->drives[drive->dn ^ 1]; + ide_drive_t *pair = ide_get_paired_drive(drive); u32 speedt = 0; u16 speedp = 0; unsigned long addr = siimage_seldev(drive, 0x04); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |