lkml.org 
[lkml]   [2007]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.23-mm1 - build failure with advansys
    Andrew Morton writes:

    > On Sat, 13 Oct 2007 10:14:22 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:

    > > The functions virt_to_bus and bus_to_virt are begin defined between ifdef CONFIG_PPC32
    > > but when i compile allyesconfig with ppc64 box,i get this error. This patch removes the
    > > ifdef.

    Which is totally bogus, because virt_to_bus/bus_to_virt only work on
    systems without an IOMMU. Most if not all ppc64 systems have one or
    more IOMMUs. This patch is nacked.

    The correct fix is to make advansys depend on CONFIG_VIRT_TO_BUS, or
    alternatively fix advansys.c properly by making it use the interfaces
    described in Documentation/DMA-mapping.txt (or the equivalent scsi
    helpers).

    > Please copy the powerpc developers on powerpc patches.

    Definitely.

    Paul.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-18 02:11    [W:0.018 / U:23.228 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site