lkml.org 
[lkml]   [2007]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.23-mm1: BUG in reiserfs_delete_xattrs
    Le 12.10.2007 06:31, Andrew Morton a écrit :
    > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/

    /home is mounted with the following options:
    /dev/mapper/vglinux1-lvhome on /home type reiserfs (rw,noatime,nodiratime,user_xattr)

    I guess that beagled (the Beagle desktop search daemon) has populated user
    xattrs on almost all files. Now, when I delete a file, two BUGs occur
    and the system hangs. Here is the stack for the first BUG (the second
    one is very similar):

    [partially hand copied stack]
    _fput
    fput
    reiserfs_delete_xattrs
    reiserfs_delete_inode
    generic_delete_inode
    generic_drop_inode
    iput
    do_unlinkat
    sys_unlink
    sys_enter_past_esp

    I reported a similar BUG in 2.6.22-rc8-mm2 (see
    http://lkml.org/lkml/2007/9/27/235). Dave Hansen sent a patch for it, I
    tested it and it was OK for 2.6.22-rc8-mm2.

    I tried this patch on 2.6.23-mm1, and it fixed the BUGs here too.

    ----
    From: Dave Hansen <haveblue@us.ibm.com>

    The bug is caused by reiserfs creating a special 'struct file' with a
    NULL vfsmount.

    /* Opens a file pointer to the attribute associated with inode */
    static struct file *open_xa_file(const struct inode *inode, const char
    *name,
    int flags)
    {
    ...
    fp = dentry_open(xafile, NULL, O_RDWR);
    /* dentry_open dputs the dentry if it fails */


    As Christoph just said, this is somewhat of a bandaid. But, it
    shouldn't hurt anything.

    ---

    lxc-dave/fs/file_table.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff -puN fs/open.c~fix-reiserfs-oops fs/open.c
    diff -puN fs/file_table.c~fix-reiserfs-oops fs/file_table.c
    --- lxc/fs/file_table.c~fix-reiserfs-oops 2007-09-27 13:32:20.000000000 -0700
    +++ lxc-dave/fs/file_table.c 2007-09-27 13:33:11.000000000 -0700
    @@ -236,7 +236,7 @@ void fastcall __fput(struct file *file)
    fops_put(file->f_op);
    if (file->f_mode & FMODE_WRITE) {
    put_write_access(inode);
    - if (!special_file(inode->i_mode))
    + if (!special_file(inode->i_mode) && mnt)
    mnt_drop_write(mnt);
    }
    put_pid(file->f_owner.pid);
    diff -puN include/linux/mount.h~fix-reiserfs-oops include/linux/mount.h
    _

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-15 00:37    [W:0.021 / U:119.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site