Messages in this thread | | | Date | Sat, 13 Oct 2007 20:38:43 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [patch 7/8] b43 wireless needs <linux/io.h> |
| |
On Sat, 13 Oct 2007, Larry Finger wrote: > Geert Uytterhoeven wrote: > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' > > > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > > linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' > > > > linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': > > linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' > > From the distribution list for this E-mail, I presume this error occurred for m68k. Is this correct?
That's correct.
> If so, I will probably need to prepare a similar patch for b43legacy.
I had no problems compiling b43legacy on m68k, though. Probably <linux/io.h> was included through some other include file. Of course it's safer to always #include <linux/io.h> when using I/O.
During linking, I did get a bunch of `undefined reference to `dma_*'' errors, with both b43 and b43legacy (and a few other drivers). Probably they need to depend on HAS_DMA. I'll post separate patches for those after I've sorted them out.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |