lkml.org 
[lkml]   [2007]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] hiddev: Add 32bit ioctl compatibilty
    On Fri, Oct 12, 2007 at 04:51:00PM -0700, Philip Langdale wrote:
    > The hiddev driver currently lacks 32bit ioctl compatibility, so
    > if you're running with a 64bit kernel and 32bit userspace, it won't
    > work.
    >
    > I'm pretty sure that the only thing missing is a compat_ioctl
    > implementation as all structs have fixed size fields.
    >
    > +static long hiddev_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
    > +{
    > + struct inode *inode = file->f_path.dentry->d_inode;
    > + return hiddev_ioctl(inode, file, cmd, compat_ptr(arg));
    > +}

    Just how many instances of that sucker do we need? It's nothing but

    struct inode *inode = file->f_path.dentry->d_inode;
    return file->f_op->ioctl(inode, file, cmd, compat_ptr(arg));
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-13 02:05    [W:0.020 / U:117.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site