lkml.org 
[lkml]   [2007]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver
    Hi Ahmed,

    On 10/12/07, Ahmed S. Darwish <darwish.07@gmail.com> wrote:
    > On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
    > >
    > > Signed-off-by: Bryan Wu <bryan.wu@analog.com>
    > > ---
    >
    > Hi Bryan,
    >
    > Why creating module's own kthread to call ad7142_decode and process keycodes
    > instead of using a tasklet ?
    >

    Yo can't access i2c from a tasklet context.

    > Isn't disabling device interrupts from the begining of the ISR "ad7142_interrupt"
    > till the kthread "ad7142_thread" got waked-up and scheduled a long time,
    > espicially if there's a high load on the userspace side ?
    >

    It is OK - you disable a specific interrupt line preventing it from
    raising any more IRQs until current one is serviced. This is different
    from disabling interrupts on CPU.

    > Minor issues below.
    >
    > > +
    > > +/* R ADC stage 0 - 11 result (uncompensated) actually located in SRAM */
    > > +#define ADCRESULT_S0 0x0B
    > > +#define ADCRESULT_S1 0x0C
    > > +#define ADCRESULT_S2 0x0D
    > > +#define ADCRESULT_S3 0x0E
    > > +#define ADCRESULT_S4 0x0F
    > > +#define ADCRESULT_S5 0x10
    > > +#define ADCRESULT_S6 0x11
    > > +#define ADCRESULT_S7 0x12
    > > +#define ADCRESULT_S8 0x13
    > > +#define ADCRESULT_S9 0x14
    > > +#define ADCRESULT_S10 0x15
    > > +#define ADCRESULT_S11 0x16
    > > +
    >
    > Keeping last two lines aligned with their above counterparts ?

    I believe they are aligned if you aplly the patch.

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-12 19:33    [W:3.588 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site