Messages in this thread Patch in this message | | | Date | Fri, 12 Oct 2007 10:08:49 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: Interaction between Xen and XFS: stray RW mappings |
| |
Jeremy Fitzhardinge wrote: > I guess we could create a special-case interface to do the same thing > with XFS mappings, but it would be nicer to have something more generic. > > Is my analysis correct? Or should XFS not be holding stray mappings? > Or is there already some kind of generic mechanism I can use to get it > to release its mappings?
This test patch confirms my theory:
diff -r 36a518c1fb4b fs/xfs/linux-2.6/xfs_buf.c --- a/fs/xfs/linux-2.6/xfs_buf.c Fri Oct 12 10:03:56 2007 -0700 +++ b/fs/xfs/linux-2.6/xfs_buf.c Fri Oct 12 10:07:03 2007 -0700 @@ -186,6 +186,11 @@ free_address( void *addr) { a_list_t *aentry; + +#ifdef CONFIG_XEN + vunmap(addr); + return; +#endif aentry = kmalloc(sizeof(a_list_t), GFP_NOWAIT); if (likely(aentry)) {
With this in place, the problem goes away.
J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |