[lkml]   [2007]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch] modpost problem when symbols move from one module to another
The v4l-dvb tree recently renamed a module and this caused some problems
with modpost creating incorrect module dependencies. This patch fixes that
problem. It should be explained thoroughly in the patch description.modpost: Fix problem with out of date Module.symvers

When part of build an external module tree, modpost first reads in the
kernel's and then the external tree's Module.symvers files. From these files
it establishes a symbol => module mapping. When it later reads in each module
built and processes the symbols it finds, it discovers the symbol=>module
mapping from Module.symvers and leaves it as it is.

The problem comes with a module has been re-named or a symbol has moved from
one module to another, since the Module.symvers file was generated. modpost
does not update the symbol=>module mapping when it finds the new location of
the symbol when scanning the newly built modules. This results in the module
containing incorrect dependency information and the new Module.symvers file
written by modpost will also contain the incorrect mappings, perpetuating the
problem to the next build, and so on.

When building the out of kernel development tree for kernel subsystem, like
v4l-dvb or ALSA, deleting the external Module.symvers file before building
(which the kernel build system doesn't do and shouldn't be necessary anyway),
won't fix the problem. modpost still reads the kernel's Module.symvers, and
since we a building a kernel subsystem, it will define the same symbols as the
external modules.

Signed-off-by: Trent Piepho <>

diff -r 79f0ea1e0e70 scripts/mod/modpost.c
--- a/scripts/mod/modpost.c Tue Oct 09 21:00:40 2007 +0000
+++ b/scripts/mod/modpost.c Thu Oct 11 15:20:01 2007 -0700
@@ -268,6 +268,9 @@ static struct symbol *sym_add_exported(c
"was in %s%s\n", mod->name, name,
is_vmlinux(s->module->name) ?"":".ko");
+ } else {
+ /* In case Modules.symvers was out of date */
+ s->module = mod;
s->preloaded = 0;
 \ /
  Last update: 2007-10-12 01:43    [W:0.055 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site