lkml.org 
[lkml]   [2007]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] FAT: Fix printk format strings.
From
Date
Bodo Eggert <7eggert@gmx.de> writes:

> Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
>> This makes sure printk format strings contain no more than a single
>> line.
>
>> printk(KERN_WARNING
>> - "FAT: Did not find valid FSINFO signature.\n"
>> + "FAT: Did not find valid FSINFO signature.\n");
>> + printk(KERN_WARNING
>> " Found signature1 0x%08x signature2 0x%08x"
>> " (sector = %lu)\n",
>
> What about something like
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x; expected 0x%08x, 0x%08\n" ?
> or
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x\n" ?

Looks good to me. I'll modify a patch, and apply it.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-11 19:59    [W:0.038 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site