Messages in this thread Patch in this message | | | Date | Thu, 11 Oct 2007 08:28:00 -0400 | From | "Mike D. Day" <> | Subject | [PATCH] fix minor problems in checkpatch.pl-next |
| |
When forming the prefix to output error msgs in gnu gcc format, the lack of a type ($ or @) when referencing ARGV causes error messages.
When invoked to check source files, the linenumber was off by +3 in the gcc format output.
Signed-off-by: Mike D. Day <ncmike@ncultra.org>
--- checkpatch.pl-next 2007-10-11 07:28:41.000000000 -0400 +++ /home/mdday/bin/checkpatch 2007-10-11 08:16:07.000000000 -0400 @@ -452,7 +452,6 @@ my $rawline = $line; - $prefix = "ARGV:$linenr: " if ($emacs); #extract the filename as it passes if ($line=~/^\+\+\+\s+(\S+)/) { @@ -517,6 +516,9 @@ my $herecurr = "$here\n$line\n"; my $hereprev = "$here\n$prevline\n$line\n"; + $prefix = "@ARGV:$realline: " if ($emacs && $file); + $prefix = "@ARGV:$linenr: " if ($emacs && !$file); + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report. -- Mike Day http://www.ncultra.org AIM: ncmikeday | Yahoo IM: ultra.runner PGP key: http://www.ncultra.org/ncmike/pubkey.asc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |