lkml.org 
[lkml]   [2007]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree)
    Alexey Dobriyan wrote:
    > ["if (!x & y)" patch from yanzheng@]
    > ["if (!x & y)" patch from adobriyan@]
    > ["if (!x & y)" patches from viro@]
    >
    > While we're at it, below is somewhat ugly sparse patch for detecting
    > "&& 0x" typos.

    Excellent idea! I think it applies to || as well. I'll most likely
    add a -Wboolean-logic-on-bit-constant to turn this warning on.

    Any reason why this wouldn't apply to octal constants or to GCC's new
    binary constants? I can trivially modify this patch to handle those
    as well, just by dropping the check for an 'x' or 'X', and renaming the
    flag.

    As far as patch beauty goes, I think this patch looks just fine.

    - Josh Triplett

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-10 13:49    [W:0.023 / U:30.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site