Messages in this thread | | | Date | Mon, 01 Oct 2007 18:01:58 +0200 | From | Cedric Le Goater <> | Subject | Re: [PATCH 3/5] Move the IPC namespace under the option |
| |
Pavel Emelyanov wrote: > Currently all the IPC namespace management code is in > ipc/util.c. I moved this code into ipc/namespace.c file > which is compiled out when needed. > > The linux/ipc_namespace.h file is used to store the > prototypes of the functions in namespace.c and the stubs > for NAMESPACES=n case. This is done so, because the stub > for copy_ipc_namespace requires the knoweledge of the > CLONE_NEWIPC flag, which is in sched.h. But the linux/ipc.h > file itself in included into many many .c files via the > sys.h->sem.h sequence so adding the sched.h into it will > make all these .c depend on sched.h which is not that good. > On the other hand the knowledge about the namespaces stuff > is required in 4 .c files only. > > Besides, this patch compiles out some auxiliary functions > from ipc/sem.c, msg.c and shm.c files. It turned out that > moving these functions into namespaces.c is not that easy > because they use many other calls and macros from the original > file. Moving them would make this patch complicated. On the > other hand all these functions can be consolidated, so I > will make it separately a bit later. > > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Fine with me.
Acked-by: Cedric Le Goater <clg@fr.ibm.com>
Thanks !
C. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |