Messages in this thread | | | Date | Tue, 09 Jan 2007 05:12:46 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support |
| |
Mikael Pettersson wrote: > This patch implements a simple way of setting up per-port > flags on the SATA+PATA Promise TX2plus chips, which is a > prerequisite for supporting the PATA port on those chips. > > It is based on the observation that ap->flags isn't really > used until after ->port_start() has been invoked. So it > places the "exceptional" per-port flags array in the driver's > private host structure, and uses it in ->port_start() to > finalise the port's flags. > > This patch obsoletes the #promise-sata-pata branch included > in the #all branch. > > Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
applied patches 1-2 to #upstream. minor follow-up comments follow in separate emails.
Thanks a bunch for working on this, sata_promise has needed some "love" for quite a while.
Any chance you could be talked to becoming "official" sata_promise maintainer, by sending in a patch to MAINTAINERS?
One open issue that remains is port enumeration order. Bug reports consistently indicate that the ports are numbered on the board (visible to the naked eye) in a different manner than how the chip enumerates each port. According to the bug reports, Promise's driver enumerates the ports in the correct order.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |