Messages in this thread | | | Date | Mon, 8 Jan 2007 00:56:22 -0800 (PST) | From | Amit Choudhary <> | Subject | Re: [PATCH] include/linux/slab.h: new KFREE() macro. |
| |
--- Sumit Narayan <talk2sumit@gmail.com> wrote:
> Asking for KFREE is as silly as asking for a macro to check if kmalloc > succeeded for a pointer, else return ENOMEM. > > #define CKMALLOC(p,x) \ > do { \ > p = kmalloc(x, GFP_KERNEL); \ > if(!p) return -ENOMEM; \ > } while(0) >
There are bugs with this approach. This introduces error path leaks. If you have allocated some memory earlier, then you got to free them.
-Amit
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |