lkml.org 
[lkml]   [2007]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] include/linux/slab.h: new KFREE() macro.
    Asking for KFREE is as silly as asking for a macro to check if kmalloc
    succeeded for a pointer, else return ENOMEM.

    #define CKMALLOC(p,x) \
    do { \
    p = kmalloc(x, GFP_KERNEL); \
    if(!p) return -ENOMEM; \
    } while(0)


    On 1/8/07, Amit Choudhary <amit2030@yahoo.com> wrote:
    >
    > --- Pekka Enberg <penberg@cs.helsinki.fi> wrote:
    >
    > > On 1/8/07, Hua Zhong <hzhong@gmail.com> wrote:
    > > > > And as I explained, it can result in longer code too. So, why
    > > > > keep this value around. Why not re-initialize it to NULL.
    > > >
    > > > Because initialization increases code size.
    > >
    > > And it also effectively blocks the slab debugging code from doing its
    > > job detecting double-frees.
    > >
    >
    > Man, so you do want someone to set 'x' to NULL after freeing it, so that the slab debugging code
    > can catch double frees. If you set it to NULL then double free is harmless. So, you want something
    > harmful in the system and then debug it with the slab debugging code. Man, doesn't make sense to
    > me.
    >
    > -Amit
    >
    >
    > __________________________________________________
    > Do You Yahoo!?
    > Tired of spam? Yahoo! Mail has the best spam protection around
    > http://mail.yahoo.com
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-08 09:41    [W:0.050 / U:0.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site