Messages in this thread | | | Date | Mon, 8 Jan 2007 08:12:59 +0000 | From | Al Viro <> | Subject | Re: [PATCH] include/linux/slab.h: new KFREE() macro. |
| |
On Mon, Jan 08, 2007 at 12:05:59AM -0800, Amit Choudhary wrote:
> Attached is some code from the kernel. Expanded KFREE() has been used atleast 1000 times in the > kernel. By your logic, everyone is stupid in doing so. Something has been done atleast 1000 times > in the kernel, that looks okay. But consolidating it at one place does not look okay. I am listing > some of the 1000 places where KFREE() has been used. All this code have been written by atleast 50 > different people. From your logic they were doing "silly" things.
Very likely. Some of that is a cargo-cult programming, some is explicit logics controlling cleanup later on, some is outright racy (== everything that leaves kfree()'d pointer in shared data structure for a while). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |