Messages in this thread | | | Date | Mon, 8 Jan 2007 22:01:12 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH] Broadcom 4400 resume small fix |
| |
Dmitriy Monakhov <dmonakhov@sw.ru> : > Return value of 'pci_enable_device' was ignored in b44_resume(). > We can't ingore it because it can fail.
- Please Cc: netdev@vger.kernel.org, jeff@garzik.org and the maintainer of the driver (Gary Zambrano <zambrano@broadcom.com> as per MAINTAINERS file and the log of the driveri). - the dev_err() message fits completely on a 80 columns line. - request-irq is not checked a few lines below either.
It would be nice to avoid the free_irq/pci_disable_device dance altogether.
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |