Messages in this thread | | | From | Segher Boessenkool <> | Subject | Re: [PATCH] math-emu/setcc: avoid gcc extension | Date | Sun, 7 Jan 2007 14:27:32 +0100 |
| |
> setcc() in math-emu is written as a gcc extension statement expression > macro that returns a value. However, it's not used that way and it's > not needed like that, so just make it a do-while non-extension macro > so that we don't use an extension when it's not needed.
Looks fine, except
> -#define setcc(cc) ({ \ > +#define setcc(cc) do { \ > partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ > - partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); }) > + partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); } \ > + while (0)
closing brace on the "while" line, please.
Segher
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |