Messages in this thread Patch in this message | | | Date | Sat, 6 Jan 2007 20:22:43 +0800 | From | "Conke Hu" <> | Subject | [PATCH 3/3] atiixp.c: add cable detection support for ATI IDE |
| |
IDE HDD does not work if it uses a 40-pin PATA cable on ATI chipset. This patch fixes the bug.
Signed-off-by: Conke Hu <conke.hu@amd.com> ----------------------- --- linux-2.6.20-rc3-git4/drivers/ide/pci/atiixp.c.2 2007-01-06 19:19:35.000000000 +0800 +++ linux-2.6.20-rc3-git4/drivers/ide/pci/atiixp.c 2007-01-06 19:22:34.000000000 +0800 @@ -289,8 +289,12 @@ fast_ata_pio:
static void __devinit init_hwif_atiixp(ide_hwif_t *hwif) { + u8 udma_mode = 0; + u8 ch = hwif->channel; + struct pci_dev *pdev = hwif->pci_dev; + if (!hwif->irq) - hwif->irq = hwif->channel ? 15 : 14; + hwif->irq = ch ? 15 : 14;
hwif->autodma = 0; hwif->tuneproc = &atiixp_tuneproc; @@ -306,8 +310,12 @@ static void __devinit init_hwif_atiixp(i hwif->mwdma_mask = 0x06; hwif->swdma_mask = 0x04;
- /* FIXME: proper cable detection needed */ - hwif->udma_four = 1; + pci_read_config_byte(pdev, ATIIXP_IDE_UDMA_MODE + ch, &udma_mode); + if ((udma_mode & 0x07) >= 0x04 || (udma_mode & 0x70) >= 0x40) + hwif->udma_four = 1; + else + hwif->udma_four = 0; + hwif->ide_dma_host_on = &atiixp_ide_dma_host_on; hwif->ide_dma_host_off = &atiixp_ide_dma_host_off; hwif->ide_dma_check = &atiixp_dma_check; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |