lkml.org 
[lkml]   [2007]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH, RFC] reimplement flush_workqueue()
    On Thu, Jan 04, 2007 at 10:31:07AM -0800, Andrew Morton wrote:
    > But before we do much more of this we should have a wrapper. Umm
    >
    > static inline void block_cpu_hotplug(void)
    > {
    > preempt_disable();
    > }

    Nack.

    This will only block cpu down, not cpu_up and hence is a misnomer. I would be
    vary of ignoring cpu_up events totally in writing hotplug safe code.

    --
    Regards,
    vatsa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-05 10:07    [W:0.022 / U:1.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site