Messages in this thread | | | Date | Fri, 5 Jan 2007 08:23:51 +0000 | From | Russell King <> | Subject | Re: [PATCH] backlight control for Frontpath ProGear HX1050+ |
| |
On Fri, Jan 05, 2007 at 09:03:30AM +0100, Marcin Juszkiewicz wrote: > Index: linux-2.6.18/drivers/video/backlight/progear_bl.c > =================================================================== > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ linux-2.6.18/drivers/video/backlight/progear_bl.c 2007-01-05 08:48:41.000000000 +0100 > +static int progearbl_probe(struct platform_device *pdev) > +{ > + u8 temp; > + > + pmu_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M7101, 0); > + if(!pmu_dev) { > + printk("ALI M7101 PMU not found.\n"); > + return(-1);
There are enumerated constants for these return values. Please use the proper and appropriate constants.
> + } > + > + sb_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, 0); > + if(!sb_dev) { > + printk("ALI 1533 SB not found.\n"); > + return(-1);
Ditto.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |