lkml.org 
[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
Divy Le Ray wrote:
> From: Divy Le Ray <divy@chelsio.com>
>
> Offload packets may be DMAed long after their SGE Tx descriptors are done
> so they must remain mapped until they are freed rather than until their
> descriptors are freed. Unmap such packets through an skb destructor.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>

this is questionable and sounds like you are working around a bug. I
can't think of another driver that uses skb destructors, and I could
have sworn that skb destructors were not for drivers to use anyway

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-31 11:45    [from the cache]
©2003-2011 Jasper Spaans