lkml.org 
[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/23] clocksource: remove update_callback

* Daniel Walker <dwalker@mvista.com> wrote:

> On Wed, 2007-01-31 at 11:46 +0100, Ingo Molnar wrote:
> > * Daniel Walker <dwalker@mvista.com> wrote:
> >
> > > Uses the block notifier to replace the functionality of
> > > update_callback(). update_callback() was a special case specifically
> > > for the tsc, but including it in the clocksource structure duplicated
> > > it needlessly for other clocks.
> >
> > Firstly, it think it should be mentioned that Thomas' queue already
> > does this, in clocksource-remove-the-update-callback.patch (hence he
> > should have been Cc:-ed). Your queue 'drops' Thomas' patch then
> > redoes it here without mentioning that this is another version of
> > what is in Thomas's queue. So we get this situation:
> >
> > clocksource-remove-the-update-callback.patch
> > drop-clocksource-remove-the-update-callback.patch
> > clocksource_remove_update_callback.patch
> >
> > that all flip-flops the same thing.
>
> To be clear this change has exists for a very long time, long before
> Thomas implemented it ..

it doesnt matter who invented the wheel first, what matters is a clean
channel of communication so that we end up with the best code - and
leaving out Cc:s doesnt really help that.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-31 18:23    [W:0.074 / U:4.168 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site