[lkml]   [2007]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 23/23] clocksource tsc: add verify routine

* Daniel Walker <> wrote:

> I've included this as another user of the clocksource interface. I
> don't see a usage for this across all achitectures. So a fully generic
> version isn't needed.

well, this implementation is buggy in at least two ways:

firstly, it allows a circular verification dependency in highres+dyntick
mode between the jiffies and tsc clocksources.

secondly, verification is not done while the system is booting up:

> static void verify_tsc_freq(unsigned long unused)
> {

> + if (unlikely(system_state != SYSTEM_RUNNING))
> + goto out_timer;

so we should just go with Thomas' patch:


which has been based on and tested on actual systems affected by these

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-01-31 13:51    [W:0.165 / U:1.244 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site