Messages in this thread | | | Subject | Re: + mm-search_binary_handler-mem-limit-fix.patch added to -mm tree | From | Dmitriy Monakhov <> | Date | Tue, 30 Jan 2007 08:40:59 +0300 |
| |
> > > The function changes mem limit to USER_DS before possible modprobe, but > > > never restored it again. Truly. The road to hell is paved with good intentions.
Martin Schwidefsky <schwidefsky@de.ibm.com> writes: > On Mon, 2007-01-29 at 09:37 -0800, Andrew Morton wrote: >> hm, thanks for testing - I'll drop it. >> >> I don't really understand what's wrong with it though. Maybe it's settng >> USER_DS on kernel threads? > > For architectures with a split address space there has to be a call > set_fs(USER_DS) that switches from KERNEL_DS to USER_DS for the init > process. So far this has been done in search_binary_handler and > traditionally the kernel starts with KERNEL_DS to make the early > copy_from_user calls work. > So, what is wrong with always setting USER_DS? We are starting a user > space process after all. May be add some comment to prevent future attempts to make this place more "correct"? > > -- > blue skies, > Martin. > > Martin Schwidefsky > Linux for zSeries Development & Services > IBM Deutschland Entwicklung GmbH > > "Reality continues to ruin my life." - Calvin. > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |