lkml.org 
[lkml]   [2007]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Cbe-oss-dev] [RFC, PATCH 2/4] Add support to OProfile for profiling Cell BE SPUs -- update
From
Date
Arnd:

Well most of the patch is simply cleaning up the
pm_rtas_activate_signals() routine. I would be think
"pm_rtas_activat_signals routine cleanup" would be good.

Carl Love


On Tue, 2007-01-30 at 05:08 +0100, Arnd Bergmann wrote:
> On Monday 29 January 2007 20:47, Maynard Johnson wrote:
> > The code was setting up the debug bus for group 21 when profiling on the
> > event PPU CYCLES. The debug bus is not actually used by the hardware
> > performance counters when counting PPU CYCLES. Setting up the debug bus
> > for PPU CYCLES causes signal routing conflicts on the debug bus when
> > profiling PPU cycles and another PPU event. This patch fixes the code to
> > only setup the debug bus to route the performance signals for the non
> > PPU CYCLE events.
> >
> > Signed-off-by: Maynard Johnson <mpjohn@us.ibm.com>
> > Signed-off-by: Carl Love <carll@us.ibm.com>
>
> Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
>
> Any suggestion for a one-line patch title?
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-31 00:53    [W:0.224 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site