lkml.org 
[lkml]   [2007]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Cbe-oss-dev] [RFC, PATCH 1/4] Add support to OProfile for profiling Cell BE SPUs -- update
    From
    Date
    On Tue, 2007-01-30 at 14:49 -0800, Carl Love wrote:
    > Christoph:
    >
    > In our earlier work on the PPU profiling patch, Benjamin Herrenschmidt
    > said that we should remove macros that are only used once and just put
    > the actual code in. That is why the macros were removed.

    I've looked at the macros you remove and indeed, they look like stuff
    you actually want to keep in macros. I don't have off the top of my head
    the circumstances where I asked you to remove macros in the PPE code,
    but I'm sure it was different.

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-31 00:03    [W:13.468 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site