Messages in this thread | | | Date | Mon, 29 Jan 2007 12:11:15 +0100 | From | Nick Piggin <> | Subject | Re: [patch 9/9] mm: fix pagecache write deadlocks |
| |
On Mon, Jan 29, 2007 at 11:33:03AM +0100, Nick Piggin wrote: > + } else { > + char *src, *dst; > + src = kmap(src_page); > + dst = kmap(page); > + memcpy(dst + offset, > + src + ((unsigned long)buf & ~PAGE_CACHE_MASK), > + bytes); > + kunmap(page); > + kunmap(src_page); > + copied = bytes; > + } > flush_dcache_page(page);
Hmm, I guess these should use kmap_atomic with KM_USER[01]?
The kmap is from an earlier iteration that wanted to sleep with the page mapped into kernel. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |