lkml.org 
[lkml]   [2007]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 4/5][AIO] - AIO completion signal notification
On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote:
> > > + if (unlikely(!notify->sigq))
> > > + return -EAGAIN;
> >
> > Did this just leak a ref on the task_struct?
> >
>
> No, the ref is released in really_put_req() when we dispose of
> the iocb.

And the code really needs a comment explaining this. I tripped over
this before, and I think it's even already the second time Andrew
stumbled over it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-25 07:23    [W:0.663 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site