lkml.org 
[lkml]   [2007]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Add a rounddown_pow_of_two() macro to log2.h.

    In the same way that include/linux/log2.h defines the
    roundup_pow_of_two() macro, define the rounddown_pow_of_two() macro so
    peopls can stop re-implementing this operation using a loop.

    Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

    ---

    compile tested on x86 using "make allyesconfig", but there wasn't
    much chance of the build failing anyway since the patch only adds the
    macro definition, it doesn't change any existing code to use it.
    those patches will be submitted later, bit by bit.

    diff --git a/include/linux/log2.h b/include/linux/log2.h
    index d02e1a5..6cf7081 100644
    --- a/include/linux/log2.h
    +++ b/include/linux/log2.h
    @@ -52,6 +63,15 @@ unsigned long __roundup_pow_of_two(unsigned long n)
    return 1UL << fls_long(n - 1);
    }

    +/*
    + * round down to nearest power of two
    + */
    +static inline __attribute__((const))
    +unsigned long __rounddown_pow_of_two(unsigned long n)
    +{
    + return 1UL << (fls_long(n) - 1);
    +}
    +
    /**
    * ilog2 - log of base 2 of 32-bit or a 64-bit unsigned value
    * @n - parameter
    @@ -154,4 +174,20 @@ unsigned long __roundup_pow_of_two(unsigned long n)
    __roundup_pow_of_two(n) \
    )

    +/**
    + * rounddown_pow_of_two - round the given value down to nearest power of two
    + * @n - parameter
    + *
    + * round the given value down to the nearest power of two
    + * - the result is undefined when n == 0
    + * - this can be used to initialise global variables from constant data
    + */
    +#define rounddown_pow_of_two(n) \
    +( \
    + __builtin_constant_p(n) ? ( \
    + (n == 1) ? 0 : \
    + (1UL << ilog2(n)) : \
    + __rounddown_pow_of_two(n) \
    + )
    +
    #endif /* _LINUX_LOG2_H */
    --
    ==============================================================================================
    Robert P. J. Day
    Linux Consulting, Training and Annoying Kernel Pedantry
    Waterloo, Ontario, CANADA
    http://www.fsdev.dreamhosters.com/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
    ==============================================================================================
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-01-25 11:43    [W:8.464 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site