lkml.org 
[lkml]   [2007]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
At Thu, 25 Jan 2007 12:30:44 -0500,
xiphmont@xiph.org wrote:
>
> > I'm working on this now and will doublecheck just in case my test was
> > flawed first time.
>
> Doublechecking indicates my initial test was wrong somehow; both
> card->dev->parent and card->parent passed as arg 2 to the
> device_create call in snd_register_device result in correct device
> symlinks. Are these two actually semantically different? I'm just
> curious.

If card->dev is created, they should be identical.
But, again, card->dev should be NULL on the older systems.

> The call to device_create in cound_core.c:sound_insert_unit also needs
> to be modified in order for the device symlinks in the other unit
> types to be correct. Again, modifying the 'dev' argument to
> '(dev?dev->parent:NULL)' appears to fix the problem. Is that
> correct/appropriate there?

Your change breaks the expected heavior if CONFIG_SYSFS_DEPRECATED is
enabled. Then devices won't belong to card* objects any more...


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-25 18:51    [W:0.721 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site