Messages in this thread | | | Date | Wed, 24 Jan 2007 17:30:59 +0100 | From | Roger While <> | Subject | [PATCH] gpu/radeonfb: add GPU support to radeonfb |
| |
@@ -241,9 +241,9 @@ void radeonfb_engine_reset(struct radeon INREG(HOST_PATH_CNTL); OUTREG(HOST_PATH_CNTL, host_path_cntl);
- if (rinfo->family != CHIP_FAMILY_R300 || - rinfo->family != CHIP_FAMILY_R350 || - rinfo->family != CHIP_FAMILY_RV350) + if (rinfo->gpu_info->family != CHIP_FAMILY_R300 || + rinfo->gpu_info->family != CHIP_FAMILY_R350 || + rinfo->gpu_info->family != CHIP_FAMILY_RV350) OUTREG(RBBM_SOFT_RESET, rbbm_soft_reset);
Alarm bells going off - "!=" combined with "||" ? Looks like a reset will always be done.
Roger While
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |