Messages in this thread | | | Date | Wed, 24 Jan 2007 20:26:16 -0800 | From | Greg KH <> | Subject | Re: [PATCH] alsa: correct nonsensical sysfs device symlinks |
| |
On Wed, Jan 24, 2007 at 08:50:06PM -0500, Christopher Monty Montgomery wrote: > This patch was generated against 2.6.20-rc5; it fixes a bug that > cropped up in a late 2.6.19-mm kernel. > > When ALSA's sysfs device creation was converted from using > class_device_create() to device_create(), the fourth param from > class_device_create() [dev] was simply plugged into arg 2 of > device_create(). This causes the device symlinks under all the > class/sound/[node] to point to nonsensical places. Among other > problems, this breaks HAL and all audio software that depends on HAL.
I don't understand, where does the symlink currently point to? It looks correct to me on my machines:
$ tree /sys/class/sound/ /sys/class/sound/ |-- card0 -> ../../devices/pci0000:00/0000:00:1b.0/card0 |-- controlC0 -> ../../devices/pci0000:00/0000:00:1b.0/card0/controlC0 |-- pcmC0D0c -> ../../devices/pci0000:00/0000:00:1b.0/card0/pcmC0D0c |-- pcmC0D0p -> ../../devices/pci0000:00/0000:00:1b.0/card0/pcmC0D0p |-- pcmC0D2c -> ../../devices/pci0000:00/0000:00:1b.0/card0/pcmC0D2c |-- pcmC0D6c -> ../../devices/pci0000:00/0000:00:1b.0/card0/pcmC0D6c |-- pcmC0D6p -> ../../devices/pci0000:00/0000:00:1b.0/card0/pcmC0D6p `-- timer -> ../../devices/virtual/sound/timer
What do the symlinks look on your machine?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |