lkml.org 
[lkml]   [2007]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 002 of 4] md: Make 'repair' actually work for raid1.
    On Tuesday January 23, akpm@osdl.org wrote:
    > On Tue, 23 Jan 2007 11:26:52 +1100
    > NeilBrown <neilb@suse.de> wrote:
    >
    > > + for (j = 0; j < vcnt ; j++)
    > > + memcpy(page_address(sbio->bi_io_vec[j].bv_page),
    > > + page_address(pbio->bi_io_vec[j].bv_page),
    > > + PAGE_SIZE);
    >
    > I trust these BIOs are known to only contain suitably-allocated, MD-private
    > pages? Because if these pages can be user pages then this change is
    > spectacularly buggy ;)

    Your trust is well placed.
    This is in the 'resync' path, were all buffers are allocated in lowmem
    and are full pages and so-forth, so this is perfectly safe.

    NeilBrown
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-24 09:09    [W:0.020 / U:60.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site