lkml.org 
[lkml]   [2007]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs
On 1/23/07, Dale Farnsworth <dale@farnsworth.org> wrote:
> From Dale Farnsworth <dale@farnsworth.org>
>
> mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs
>
> This bug was found and isolated by Thibaut VARENE <T-Bone@parisc-linux.org>
> and Jarek Poplawski <jarkao2@o2.pl>. This patch is a modification of their
> fixes. We acquire and release the lock for each descriptor that is freed
> to minimize the time the lock is held.
>
> ---
>
> drivers/net/mv643xx_eth.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> index c41ae42..b3bf864 100644
> --- a/drivers/net/mv643xx_eth.c
> +++ b/drivers/net/mv643xx_eth.c
> @@ -332,13 +339,13 @@ int mv643xx_eth_free_tx_descs(struct net
> if (skb)
> mp->tx_skb[tx_index] = NULL;
>
> - spin_unlock_irqrestore(&mp->lock, flags);
> -
> if (cmd_sts & ETH_ERROR_SUMMARY) {
> printk("%s: Error in TX\n", dev->name);
> mp->stats.tx_errors++;
> }

Note that this printk probably won't show immediately because IRQs are
disabled. But that's maybe not a big deal.

HTH

--
Thibaut VARENE
http://www.parisc-linux.org/~varenet/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-23 19:01    [from the cache]
©2003-2011 Jasper Spaans