Messages in this thread | | | Date | Tue, 23 Jan 2007 12:43:12 +0000 | From | Russell King <> | Subject | Re: [patch 03/26] Dynamic kernel command-line - arm |
| |
On Tue, Jan 23, 2007 at 01:59:14PM +0200, Alon Bar-Lev wrote: > On 1/23/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote: > >> Rossell, I am confused. > >> There are many places in kernel where there is static __initdata > >> without initialization. Should all these be corrected too? Or your > >> comment applies only to none static global data? > > > >From what I remembered from previous mails on this list (which is what > >caused me to pick up on this), and what I later quoted from the gcc > >manual, all those places (where something is marked __initdata but is > >not explicitly initialised) would appear to be incorrect. > > > >So they should probably be fixed up. > > Well... A lot of places in the kernel needs to be fixed, regardless > this patch... I can probably creat a patch for this as well... But > since I don't an expert in this one... We need to be sure this should > be fixed.
Don't particularly care; the amount of time spent discussing this issue is becoming rather rediculous, so I'd rather we reached some conclusion very soon; to this end this is going to be my last response on this subject.
I suggest that we leave what's already there, but any new instances we create are correct to the gcc manual.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |