lkml.org 
[lkml]   [2007]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM
On Sun, 21 Jan 2007 20:13:00 +0100
Adrian Bunk <bunk@stusta.de> wrote:

> Using assembler code for performance in drivers might have been a good
> idea 15 years ago when this code was written, but with today's compilers
> that's unlikely to be an advantage.
>
> Besides this, it also hurts the readability.
>
> Simply use the C code that was already there as an alternative.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
"stosb\n\t"

NAK

The C codepaths are essentially untested on this driver.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-22 16:35    [W:0.206 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site