Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Tue, 23 Jan 2007 11:26:56 +1100 | Subject | [PATCH 003 of 4] md: Make sure the events count in an md array never returns to zero. |
| |
Now that we sometimes step the array events count backwards (when transitioning dirty->clean where nothing else interesting has happened - so that we don't need to write to spares all the time), it is possible for the event count to return to zero, which is potentially confusing and triggers and MD_BUG.
We could possibly remove the MD_BUG, but is just as easy, and probably safer, to make sure we never return to zero.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output ./drivers/md/md.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff .prev/drivers/md/md.c ./drivers/md/md.c --- .prev/drivers/md/md.c 2007-01-23 11:13:44.000000000 +1100 +++ ./drivers/md/md.c 2007-01-23 11:23:58.000000000 +1100 @@ -1633,7 +1633,8 @@ repeat: * and 'events' is odd, we can roll back to the previous clean state */ if (nospares && (mddev->in_sync && mddev->recovery_cp == MaxSector) - && (mddev->events & 1)) + && (mddev->events & 1) + && mddev->events != 1) mddev->events--; else { /* otherwise we have to go forward and ... */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |