Messages in this thread | | | Date | Mon, 15 Jan 2007 20:14:06 -0800 | From | Paul Jackson <> | Subject | Re: [PATCH] CPUSET related breakage of sys_mbind |
| |
Christoph wrote: > Cpusets is your thing so I think you could fix this the right way.
But wasn't it your patch that broke ...
Actually, I'd have blessed Bob Picco's patch, as it's done the right way, with a cpuset_* macro hook, defined twice in cpuset.h, with and without CONFIG_CPUSET, where the without case compiles to a no-op. This is the same way as is used for the couple dozen other cpuset kernel hooks.
But I thought you were already signed up for this one, so I didn't want to trample on your efforts.
And, perhaps more important, I understood you had some other patches in the works that have cpuset hooks. I'm thinking it would be a good idea to learn how these hooks are done, so we don't have to come around here again.
How about this ... you take another look at Bob's patch. If it's ok by you too, then we can both bless it, and that should do it.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |