lkml.org 
[lkml]   [2007]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)
On Mon, Jan 15, 2007 at 07:38:10PM +0100, Marcel Holtmann wrote:
> Hi Vojtech,
>
> > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h.
> >
> > Do you think that makes sense? It's code, not a header file.
> >
> > > Should I wait for an updated patch that uses hid-debug.h again?
>
> actually that code shouldn't be in a header file at all. It should be
> drivers/hid/hid-debug.c and the Makefile should compile it conditionally
> depending on a Kconfig option.

Agreed. It was a .h file just because of me being lazy.

--
Vojtech Pavlik
Director SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-15 20:43    [W:0.050 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site