lkml.org 
[lkml]   [2007]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] fixing errors handling during pci_driver resume stage [ata]
    On Tue, Jan 09, 2007 at 12:01:28PM +0300, Dmitriy Monakhov wrote:
    > ata pci drivers have to return correct error code during resume stage in
    > case of errors.
    ...
    > @@ -6246,8 +6253,10 @@ int ata_pci_device_suspend(struct pci_de
    > int ata_pci_device_resume(struct pci_dev *pdev)
    > {
    > struct ata_host *host = dev_get_drvdata(&pdev->dev);
    > + int err;
    >
    > - ata_pci_device_do_resume(pdev);
    > + if ((err = ata_pci_device_do_resume(pdev)))
    > + return err;

    nit: in every other case I looked at you did:
    err = foo()
    if (err) ...

    Can you make that consistent here too?

    thanks,
    grant
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-13 01:31    [W:0.044 / U:61.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site