lkml.org 
[lkml]   [2007]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] kbuild: Don't ignore localversion files if the path includes a ~
Hi Kai, Sam

The following patch fixes the problem that localversion files where
ignored if the tree lives in a path which contains a ~. It changes the
test to apply to the filename only.

Debian allows versions which contains ~ in it. The upstream part of the
version is in the directory name of the build tree and we got weird
results because the localversion files was just got ignored in this
case.

--- a/Makefile
+++ b/Makefile
@@ -807,7 +807,7 @@ space := $(nullstring) # end of line
___localver = $(objtree)/localversion* $(srctree)/localversion*
__localver = $(sort $(wildcard $(___localver)))
# skip backup files (containing '~')
-_localver = $(foreach f, $(__localver), $(if $(findstring ~, $(f)),,$(f)))
+_localver = $(foreach f, $(__localver), $(if $(findstring ~, $(notdir $(f))),,$(f)))

localver = $(subst $(space),, \
$(shell cat /dev/null $(_localver)) \
--
Totally illogical, there was no chance.
-- Spock, "The Galileo Seven", stardate 2822.3
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-01-10 13:07    [W:0.025 / U:2.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site